Code review comment for ~rodrigo-barbieri2010/stsstack-bundles:demo_networks

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Hi Rodrigo, thanks for taking the time to look at this code. I think it might be better to add this as a new script/tool (i.e. under /tools) so that people can have an easy way to create arbitrary networks. I can see the benefit of having an extra network but personally i don't want to have one whenever i do a deployment and for debug and comparison purposes it actually helps me if the segmentation id is always the same (since if it changes it is yet another thing to identify). Also regarding moving router creation, I think the reason why router and network creation were kept in separate scripts was somewhat for this reason. Typically a tenant will have a one router with one or more networks attached. Maybe lets have a think about how we can make this work for everybody.

« Back to merge proposal