Code review comment for ~rodrigo-barbieri2010/maas:bug/1898122
Revision history for this message
| Rodrigo Barbieri (rodrigo-barbieri2010) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Pushed new patch:
- Changed return value to DHCP instead of STATIC_IP, as suggested by reviewers (please refer to my previous comment for re-analysis of this)
- Added new unit test for the Release API. Found 1 that almost captured the bug, so cloned it with a slight modification to make it go through the failed code
- Tested unit test, it fails without the fix
@Bjorn: I had previously assumed you meant a functional test, but I didn't find existing Release API functional tests to add a new test to (not sure if I didn't look in the right places), so I added a unit test, which captured the bug.
Waiting for reviews on new patchset.