Code review comment for lp:~rocky-burt/trac-bzr/bug-263300

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Rocky Burt wrote:
> Rocky Burt has proposed merging lp:~rocky-burt/trac-bzr/bug-263300 into lp:trac-bzr.
>
> Requested reviews:
> Trac-bzr-team (trac-bzr-team)
>
> The _get_weave call has been replaced, and the tests that failed on that now run on bzr 1.12
>
vote reject

This adds a call to Repository.get_revision_inventory, which is very
slow compared to e.g. _get_weave or get_parent_map(), especially on
repositories with large inventories.

repo.texts really should be used here to obtain the ancestry, as can be
done with get_parent_map() and bzrlib.graph.Graph.

Cheers,

jelmer

« Back to merge proposal