Ubuntu One Music App for iOS

Code review comment for lp:~rockstar/ubuntuone-ios-music/polish-list-views

  1. polish-list-views
  2. Merge into trunk
Revision history for this message
Mike McCracken (mikemc) wrote :

Separate changes I see in here that could have been multiple branches:
- adding SSPullToRefresh
- songsForArtistID bug fix
- songlistcell art downloading

1. The license for sspulltorefresh probably needs to be included:
https://github.com/soffes/sspulltorefresh/blob/master/LICENSE

1a. Do we need the GPL on each of the source files? That's what we do
in the python apps...

2. Do we localize this app? The hard-coded english pluralization made
me wonder.

3. In SongListCell.m, should the downloader completionBlock also set
song.art? Otherwise it looks like we'll be downloading it every time
it shows up...

review: Needs Information

« Back to merge proposal