Code review comment for lp:~rockstar/loggerhead/revnocache
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
review:
Needs Resubmitting
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hm, I think this branch may be guilty of trying to do too many things at once. I think there are two separate tasks: (1) use revnocache to make accessing the merge sorted revision graph more efficient (2) reducing the use of whole-history data in history.py. This sort of tries to do both :/
Also, it makes loggerhead hard-depend on revnocache being installed, which isn't great. So, sorry, I think we'll have to try again here... and I'm going on leave for a week so we don't really have a chance to talk about what would be better. Oops.