Test case in lib/lp/soyuz/tests/test_sourcepackagerelease.py is missing a lot of docstrings.
> def test_uploader_no_uploader(self):
You shouldn't test for equality to None, use assertIs instead. self.assertIs(None, spr.uploader)
Also don't split the lines if they don't need it.
> def test_uploader_dsc_package(self):
Instead of testing against spr.dscsigningkey.owner, just use 'owner' as you created it in the test. It makes the test more obvious.
self.assertEqual(owner, spr.uploader)
> def test_uploader_recipe(self):
Keep the assertEqual on one line.
Thanks for the other lint cleanup.
« Back to merge proposal
Test case in lib/lp/ soyuz/tests/ test_sourcepack agerelease. py is missing a lot
of docstrings.
> def test_uploader_ no_uploader( self):
You shouldn't test for equality to None, use assertIs instead. assertIs( None, spr.uploader)
self.
Also don't split the lines if they don't need it.
> def test_uploader_ dsc_package( self):
Instead of testing against spr.dscsigningk ey.owner, just use 'owner' as you
created it in the test. It makes the test more obvious.
self. assertEqual( owner, spr.uploader)
> def test_uploader_ recipe( self):
Keep the assertEqual on one line.
Thanks for the other lint cleanup.