Code review comment for lp:~rockstar/entertainer/trial-integration

> What is the actual new work on this branch? Just removing the run_tests,
> renaming the files, and moving the music tests? I can see that the to_dict
> branch was merged in, as was the small change to GNOME from Kmos.
>

Well, originally, I started out trying to integrate trial's python API into the
current test runner. I abandoned that idea when I realized I'd rather not
maintain more code than I needed. That's why this results in such a small
amount of work now. Smarter not harder or something like that.

> There are twenty missing tests (234 to 214) between the trunk and your
> branch. Any clue where those tests went? Did you consolidate all the music
> tests correctly?

I'm checking now, but basically, the tests were merged by doing
`cat this_test.py >> that_test.py` so I can't see how I missed something. It
might be that trial is not running inherited tests of something, where the
original test runner would have (and maybe the former is the correct
behavior). I'll verify and post what I find.

--
Paul Hummer
http://theironlion.net
1024/862FF08F C921 E962 58F8 5547 6723 0E8C 1C4D 8AC5 862F F08F