Code review comment for lp:~rockstar/entertainer/package-structure-apocalypse

On Thu, 07 May 2009 19:59:33 -0000, Samuel Buffet <email address hidden>
> My questions are.
>
> Why db isn't under backend? and why gui is not under client?

db is a core part of entertainer. I tried to make thinngs more easily
accessible, and once I get the network stuff in, it won't be used by just one
package.

> You write that you're about to remove entertainerlib.backend but I don't
> understand right now why you don't rename it in entertainerlib.server? Does
> that mean that the server's code will take place elsewhere?

Because there won't be just one entertainer server. There will be with 0.5,
but the end goal is to provide more options. I figure something like
entertainerlib.network.local.Server and entertainerlib.network.dlna.Server,
etc.

Now you'll see why db didn't stay in the backend.

Also, most of the backend code is pure crap now, being replaced, and will be
completely removed. THAT's why I didn't move it to a new location. :)

>> Note :
>
> Entertainer is broken if the notification icon is activated. See below the
> traceback :
>
> (/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainer:31123):
> libglade-WARNING **: could not find glade file
> '/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainerlib/gui/glade/system_tray_icon_menu.glade'
> Traceback (most recent call last): File
> "/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainer",
> line 12, in <module> main() File
> "/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainerlib/client/__init__.py",
> line 33, in main client_client = Client() File
> "/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainerlib/client/client.py",
> line 51, in __init__ self.quit_client, self.toggle_interface_visibility)
> File
> "/mnt/raid/Programmes/branches_entertainer/package-structure-apocalypse/entertainerlib/gui/system_tray_icon.py",
> line 42, in __init__ os.path.join(self.GLADE_DIR,
> "system_tray_icon_menu.glade")) RuntimeError: could not create GladeXML
> object
>

I don't know yet what to with the system tray icon. No one uses it, it
doesn't really fit in with what Entertainer is (a media center, not a desktop
application) and I currently don't have any plans to support it in the local
server.

--
Paul Hummer
http://theironlion.net
1024/862FF08F C921 E962 58F8 5547 6723 0E8C 1C4D 8AC5 862F F08F