Code review comment for lp:~rockstar/entertainer/package-structure-apocalypse

Revision history for this message
Matt Layman (mblayman) wrote :

> Why db isn't under backend? and why gui is not under client?
>
> I think it's more readable and more logic because gui which contains
> widgets/screens ... are all used only by the *client* and *db* is used by the
> server (I guess).

I can't speak for db, but moving gui out of frontend was my request. I know that the frontend is currently the only thing that uses the gui module, but there is no true reason that gui needs to be a sub-module of frontend (it could theoretically be totally independent of the frontend). Moving gui out of frontend flattens the depth of the tree which I think is a good thing here. I have a feeling Paul would say the same thing about the db and the backend.

> Note :
> Entertainer is broken if the notification icon is activated. See below the
> traceback :

I agree that this needs to be fixed before the branch lands.

« Back to merge proposal