Code review comment for lp:~rockstar/entertainer/package-structure-apocalypse

Revision history for this message
Paul Hummer (rockstar) wrote :

This branch is the apocalyptical package structure changes. entertainerlib.backend will disappear as soon as the new indexer lands. There are all sorts of changes here. The only real code change was the complete removal of entertainerlib.utils.cd_utils, because there was a single line single function, which I easily removed. Otherwise, I consolidated a lot of packages into single modules, and flattened the tree a bunch.

This specifically needs to land in future, because it's unnecessary when there is still a backend/frontend. Frontend was renamed to client, and will become more of a client in later branches. entertainerlib.utils was removed, and its contents shifted around.

This is probably going to cause a lot of conflicts, which is another big reason why this needs to land in future. The future branch is there solely to be liberal in the changes that need to be made, and, well, these changes are quite liberal. Tests, lint, and running entertainer all indicate everything is good, but the jury is still out, and will require A LOT of changes.

« Back to merge proposal