Code review comment for lp:~rockstar/entertainer/add-distutils

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

=== modified file 'entertainerlib/frontend/__init__.py'
--- entertainerlib/frontend/__init__.py 2008-08-16 04:28:47 +0000
+++ entertainerlib/frontend/__init__.py 2008-10-11 20:59:42 +0000
@@ -1,1 +1,26 @@
 '''Frontend gui to entertainer'''
+
+def main(*args, **kwargs):
+ '''Frontend runner'''
+
+ # Import statements are inside thu function so that they aren't imported
+ # every time something from the frontend is imported
+ from entertainerlib.backend.backend_server import BackendServer
+ from entertainerlib.frontend.frontend_client import FrontendClient
+ from entertainerlib.utils.configuration import Configuration
+ from entertainerlib.utils.system_tray_icon import init_systray
+ from entertainerlib.frontend.translation_setup import TranslationSetup
+ TranslationSetup()

=== modified file 'entertainerlib/frontend/gui/tabs/tab.py'
--- entertainerlib/frontend/gui/tabs/tab.py 2008-10-11 13:49:43 +0000
+++ entertainerlib/frontend/gui/tabs/tab.py 2008-10-13 15:58:02 +0000
@@ -8,8 +8,11 @@

 from entertainerlib.frontend.gui.widgets.label import Label
 from entertainerlib.frontend.gui.widgets.texture import Texture
+from entertainerlib.frontend.translation_setup import TranslationSetup
 from entertainerlib.utils.configuration import Configuration

+TranslationSetup()
+
 class Tab(clutter.Group):
     """
     Tab can be used as part of the TabGroup

If you reorder the imports in entertainerlib/frontend/__init__.py main() so that the TranslationSetup() call is made before any of the frontend imports, then you won't need the changes in tab.py

« Back to merge proposal