Merge lp:~robru/unity-webapps-qml/drop-unity-dep into lp:unity-webapps-qml

Proposed by Robert Bruce Park
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~robru/unity-webapps-qml/drop-unity-dep
Merge into: lp:unity-webapps-qml
Diff against target: 73 lines (+11/-10)
2 files modified
debian/control (+10/-9)
debian/unity-webapps-qml-examples.install (+1/-1)
To merge this branch: bzr merge lp:~robru/unity-webapps-qml/drop-unity-dep
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Disapprove
Review via email: mp+195657@code.launchpad.net

Commit message

Drop unity-autopilot dep, it brings in a lot of useless stuff.

To post a comment you must log in.
75. By Robert Bruce Park

wrap-and-sort -a -t

76. By Robert Bruce Park

Shorter Vcs-Bzr link.

Revision history for this message
Robert Bruce Park (robru) wrote :

Whoops, looks like this unity-webapps dep is actually used ;-)

review: Disapprove

Unmerged revisions

76. By Robert Bruce Park

Shorter Vcs-Bzr link.

75. By Robert Bruce Park

wrap-and-sort -a -t

74. By Robert Bruce Park

Drop unity-autopilot dep, it brings in a lot of useless stuff.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-09-20 15:32:28 +0000
+++ debian/control 2013-11-18 19:11:23 +0000
@@ -7,7 +7,8 @@
7 libmessaging-menu-dev,7 libmessaging-menu-dev,
8 libnotify-dev,8 libnotify-dev,
9 libqt5webkit5-dev,9 libqt5webkit5-dev,
10 libunity-action-qt1-dev,10 libunity-action-qt1-dev,
11 libunity-dev,
11 pkg-config,12 pkg-config,
12 python (>= 2.7),13 python (>= 2.7),
13 python-setuptools,14 python-setuptools,
@@ -16,19 +17,19 @@
16 qtbase5-dev,17 qtbase5-dev,
17 qtdeclarative5-dev,18 qtdeclarative5-dev,
18 qtdeclarative5-test-plugin,19 qtdeclarative5-test-plugin,
19 libunity-dev,
20Standards-Version: 3.9.420Standards-Version: 3.9.4
21Homepage: https://launchpad.net/unity-webapp-qml21Homepage: https://launchpad.net/unity-webapp-qml
22# If you aren't a member of ~webapps but need to upload packaging changes,22# if you don't have have commit access to this branch but would like to upload
23# just go ahead. ~webapps will notice and sync up the code again.23# directly to Ubuntu, don't worry: your changes will be merged back into the
24Vcs-Bzr: https://code.launchpad.net/~webapps/unity-webapps-qml/trunk24# upstream branch
25Vcs-Bzr: lp:unity-webapps-qml
2526
26Package: unity-webapps-qml27Package: unity-webapps-qml
27Architecture: any28Architecture: any
28Multi-Arch: same29Multi-Arch: same
29Depends: libqt5webkit5-qmlwebkitplugin,30Depends: libqt5webkit5-qmlwebkitplugin,
30 qtdeclarative5-unity-action-plugin,
31 qtdeclarative5-qtquick2-plugin,31 qtdeclarative5-qtquick2-plugin,
32 qtdeclarative5-unity-action-plugin,
32 ${misc:Depends},33 ${misc:Depends},
33 ${shlibs:Depends},34 ${shlibs:Depends},
34Description: Unity Webapps QML component35Description: Unity Webapps QML component
@@ -38,8 +39,8 @@
38Package: unity-webapps-qml-examples39Package: unity-webapps-qml-examples
39Section: libs40Section: libs
40Architecture: any41Architecture: any
41Depends: unity-webapps-qml (>= ${binary:Version}),42Depends: qtdeclarative5-window-plugin,
42 qtdeclarative5-window-plugin,43 unity-webapps-qml (>= ${binary:Version}),
43 ${misc:Depends},44 ${misc:Depends},
44 ${shlibs:Depends},45 ${shlibs:Depends},
45Description: Example usage of Unity Webapps QML component46Description: Example usage of Unity Webapps QML component
@@ -61,11 +62,11 @@
61Depends: dpkg-dev,62Depends: dpkg-dev,
62 libautopilot-qt,63 libautopilot-qt,
63 libqt5test5,64 libqt5test5,
65 python-autopilot,
64 python-gobject,66 python-gobject,
65 qmlscene,67 qmlscene,
66 qtdeclarative5-unity-action-plugin,68 qtdeclarative5-unity-action-plugin,
67 qtdeclarative5-window-plugin,69 qtdeclarative5-window-plugin,
68 unity-autopilot,
69 unity-webapps-qml (>= ${source:Version}),70 unity-webapps-qml (>= ${source:Version}),
70 ${misc:Depends},71 ${misc:Depends},
71 ${python:Depends},72 ${python:Depends},
7273
=== modified file 'debian/unity-webapps-qml-examples.install'
--- debian/unity-webapps-qml-examples.install 2013-07-29 14:49:52 +0000
+++ debian/unity-webapps-qml-examples.install 2013-11-18 19:11:23 +0000
@@ -1,5 +1,5 @@
1usr/share/applications/unity-webapps-qml-basic-example.desktop1usr/share/applications/unity-webapps-qml-basic-example.desktop
2usr/share/applications/unity-webapps-qml-bbcnews-example.desktop2usr/share/applications/unity-webapps-qml-bbcnews-example.desktop
3usr/share/applications/unity-webapps-qml-facebookmessenger-example.desktop
3usr/share/applications/unity-webapps-qml-model-example.desktop4usr/share/applications/unity-webapps-qml-model-example.desktop
4usr/share/applications/unity-webapps-qml-facebookmessenger-example.desktop
5usr/share/unity-webapps-qml/examples5usr/share/unity-webapps-qml/examples

Subscribers

People subscribed via source and target branches

to all changes: