Merge lp:~robru/unity-webapps-qml/drop-unity-dep into lp:unity-webapps-qml

Proposed by Robert Bruce Park
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~robru/unity-webapps-qml/drop-unity-dep
Merge into: lp:unity-webapps-qml
Diff against target: 73 lines (+11/-10)
2 files modified
debian/control (+10/-9)
debian/unity-webapps-qml-examples.install (+1/-1)
To merge this branch: bzr merge lp:~robru/unity-webapps-qml/drop-unity-dep
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Disapprove
Review via email: mp+195657@code.launchpad.net

Commit message

Drop unity-autopilot dep, it brings in a lot of useless stuff.

To post a comment you must log in.
75. By Robert Bruce Park

wrap-and-sort -a -t

76. By Robert Bruce Park

Shorter Vcs-Bzr link.

Revision history for this message
Robert Bruce Park (robru) wrote :

Whoops, looks like this unity-webapps dep is actually used ;-)

review: Disapprove

Unmerged revisions

76. By Robert Bruce Park

Shorter Vcs-Bzr link.

75. By Robert Bruce Park

wrap-and-sort -a -t

74. By Robert Bruce Park

Drop unity-autopilot dep, it brings in a lot of useless stuff.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-09-20 15:32:28 +0000
3+++ debian/control 2013-11-18 19:11:23 +0000
4@@ -7,7 +7,8 @@
5 libmessaging-menu-dev,
6 libnotify-dev,
7 libqt5webkit5-dev,
8- libunity-action-qt1-dev,
9+ libunity-action-qt1-dev,
10+ libunity-dev,
11 pkg-config,
12 python (>= 2.7),
13 python-setuptools,
14@@ -16,19 +17,19 @@
15 qtbase5-dev,
16 qtdeclarative5-dev,
17 qtdeclarative5-test-plugin,
18- libunity-dev,
19 Standards-Version: 3.9.4
20 Homepage: https://launchpad.net/unity-webapp-qml
21-# If you aren't a member of ~webapps but need to upload packaging changes,
22-# just go ahead. ~webapps will notice and sync up the code again.
23-Vcs-Bzr: https://code.launchpad.net/~webapps/unity-webapps-qml/trunk
24+# if you don't have have commit access to this branch but would like to upload
25+# directly to Ubuntu, don't worry: your changes will be merged back into the
26+# upstream branch
27+Vcs-Bzr: lp:unity-webapps-qml
28
29 Package: unity-webapps-qml
30 Architecture: any
31 Multi-Arch: same
32 Depends: libqt5webkit5-qmlwebkitplugin,
33- qtdeclarative5-unity-action-plugin,
34 qtdeclarative5-qtquick2-plugin,
35+ qtdeclarative5-unity-action-plugin,
36 ${misc:Depends},
37 ${shlibs:Depends},
38 Description: Unity Webapps QML component
39@@ -38,8 +39,8 @@
40 Package: unity-webapps-qml-examples
41 Section: libs
42 Architecture: any
43-Depends: unity-webapps-qml (>= ${binary:Version}),
44- qtdeclarative5-window-plugin,
45+Depends: qtdeclarative5-window-plugin,
46+ unity-webapps-qml (>= ${binary:Version}),
47 ${misc:Depends},
48 ${shlibs:Depends},
49 Description: Example usage of Unity Webapps QML component
50@@ -61,11 +62,11 @@
51 Depends: dpkg-dev,
52 libautopilot-qt,
53 libqt5test5,
54+ python-autopilot,
55 python-gobject,
56 qmlscene,
57 qtdeclarative5-unity-action-plugin,
58 qtdeclarative5-window-plugin,
59- unity-autopilot,
60 unity-webapps-qml (>= ${source:Version}),
61 ${misc:Depends},
62 ${python:Depends},
63
64=== modified file 'debian/unity-webapps-qml-examples.install'
65--- debian/unity-webapps-qml-examples.install 2013-07-29 14:49:52 +0000
66+++ debian/unity-webapps-qml-examples.install 2013-11-18 19:11:23 +0000
67@@ -1,5 +1,5 @@
68 usr/share/applications/unity-webapps-qml-basic-example.desktop
69 usr/share/applications/unity-webapps-qml-bbcnews-example.desktop
70+usr/share/applications/unity-webapps-qml-facebookmessenger-example.desktop
71 usr/share/applications/unity-webapps-qml-model-example.desktop
72-usr/share/applications/unity-webapps-qml-facebookmessenger-example.desktop
73 usr/share/unity-webapps-qml/examples

Subscribers

People subscribed via source and target branches

to all changes: