Code review comment for lp:~robru/qtubuntu-cameraplugin-fake/packaging

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

nitpick:
+Depends: ${misc:Depends}, ${shlibs:Depends}

-> this should be 2 lines, with a finale , ;)

Also, looking at lintian warnings and cleaning them would be good:
W: cameraplugin-fake source: virtual-package-depends-without-real-package-depends build-depends: libgl-dev
W: cameraplugin-fake source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
W: cameraplugin-fake: description-synopsis-starts-with-article
W: cameraplugin-fake: description-starts-with-leading-spaces
W: cameraplugin-fake: extended-description-line-too-long
W: cameraplugin-fake: non-standard-dir-in-usr usr/tests/
W: cameraplugin-fake: file-in-unusual-dir usr/tests/tst_storagemanager/tst_storagemanager

For instance, I don't think we want to install in /usr/tests ;)
(Of course, impact on applications depending on that package needs to be adapated as well).

review: Needs Fixing

« Back to merge proposal