Code review comment for lp:~robru/qtmir/inline-gles

On Mon, Mar 21, 2016 at 7:55 AM, Gerry Boland
<email address hidden> wrote:
> Could you make the sed replace a bit more strict, to prevent this?

Can do.

> I'm also a giant fan of explaining non-obvious things with a comment or readme - please add a readme to explain the purpose of the *.gles and bileto scripts.

On it.

> Also, is editing "debian/copyright" necessary? Upstream name always being "qtmir" strikes me as more correct.

Well I wrote the script to minimize the diff against the existing
qtmir-gles package, eg, the existing qtmir-gles already defines
"Upstream-Name: qtmir-gles" in its debian/copyright.

Now that you mention it, since the field is called "Upstream" Name, it
does seem more correct to leave it as just qtmir, but that will
introduce a packaging diff when this code goes live.

--
robru