Code review comment for lp:~robru/qtmir/inline-gles

Revision history for this message
Gerry Boland (gerboland) wrote :

+sed --in-place 's/qtmir/qtmir-gles/g' debian/copyright debian/changelog
this will edit more than just the package names in the changelog. Example:

- * Depend on same-version qtmir-{desktop,android}
+ * Depend on same-version qtmir-gles-{desktop,android}

- * Migration of qtmir from the legacy Mir API
+ * Migration of qtmir-gles from the legacy Mir API

Could you make the sed replace a bit more strict, to prevent this?

I'm also a giant fan of explaining non-obvious things with a comment or readme - please add a readme to explain the purpose of the *.gles and bileto scripts.

Also, is editing "debian/copyright" necessary? Upstream name always being "qtmir" strikes me as more correct.

Looks fine to me otherwise.

review: Needs Fixing

« Back to merge proposal