Merge lp:~robru/qakit/new-signoff into lp:qakit

Proposed by Robert Bruce Park
Status: Merged
Approved by: Jean-Baptiste Lallement
Approved revision: 203
Merged at revision: 203
Proposed branch: lp:~robru/qakit/new-signoff
Merge into: lp:qakit
Diff against target: 30 lines (+3/-3)
1 file modified
silo-card-bot/silo_notifier (+3/-3)
To merge this branch: bzr merge lp:~robru/qakit/new-signoff
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+310491@code.launchpad.net

Description of the change

Bileto behaviour changed. New field "qa" contains the bileto-controlled states of N/A, Required, and Ready. "qa_signoff" is now entirely user-controlled Approved/Failed. No more "set download_links field in order to override qa signoff field"

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'silo-card-bot/silo_notifier'
--- silo-card-bot/silo_notifier 2016-10-26 00:49:44 +0000
+++ silo-card-bot/silo_notifier 2016-11-09 21:54:05 +0000
@@ -88,7 +88,7 @@
8888
89def get_landing_requests():89def get_landing_requests():
90 """ Load silo info from CI Train """90 """ Load silo info from CI Train """
91 landing_url = urljoin(BILETO_API_URL, 'tickets?qa_signoff=Ready')91 landing_url = urljoin(BILETO_API_URL, 'tickets?qa=Ready')
92 logging.debug('Loading data from %s', landing_url)92 logging.debug('Loading data from %s', landing_url)
93 response = urlopen(landing_url)93 response = urlopen(landing_url)
94 if response.getcode() != 200:94 if response.getcode() != 200:
@@ -308,7 +308,7 @@
308 :return: True on success308 :return: True on success
309 """309 """
310 # Safety in case filtering didn't occur before310 # Safety in case filtering didn't occur before
311 if READY not in request['qa_signoff']:311 if request['qa'] != READY:
312 return False312 return False
313313
314 landers = ", ".join(request['landers'].split())314 landers = ", ".join(request['landers'].split())
@@ -464,7 +464,7 @@
464def remove_not_ready_for_qa(api_key, token, landing_data, dry_run=False):464def remove_not_ready_for_qa(api_key, token, landing_data, dry_run=False):
465 """ Move to failed the cards that are not ready for QA anymore """465 """ Move to failed the cards that are not ready for QA anymore """
466 reqs_ready = [req['id'] for req in landing_data466 reqs_ready = [req['id'] for req in landing_data
467 if READY in req['qa_signoff']]467 if req['qa'] != READY]
468468
469 for request in get_cards_ready_for_qa(api_key, token):469 for request in get_cards_ready_for_qa(api_key, token):
470 if int(request[1]) not in reqs_ready:470 if int(request[1]) not in reqs_ready:

Subscribers

People subscribed via source and target branches