Merge lp:~robru/qakit/new-signoff into lp:qakit

[Robert Bruce Park]

Bileto behaviour changed. New field "qa" contains the bileto-controlled states of N/A, Required, and Ready. "qa_signoff" is now entirely user-controlled Approved/Failed. No more "set download_links field in order to override qa signoff field"

[Jean-Baptiste Lallement (jibel)]

thanks.

review: Approve

=== modified file 'silo-card-bot/silo_notifier'
--- silo-card-bot/silo_notifier	2016-10-26 00:49:44 +0000
+++ silo-card-bot/silo_notifier	2016-11-09 21:54:05 +0000
@@ -88,7 +88,7 @@
 
 def get_landing_requests():
     """ Load silo info from CI Train """
-    landing_url = urljoin(BILETO_API_URL, 'tickets?qa_signoff=Ready')
+    landing_url = urljoin(BILETO_API_URL, 'tickets?qa=Ready')
     logging.debug('Loading data from %s', landing_url)
     response = urlopen(landing_url)
     if response.getcode() != 200:
@@ -308,7 +308,7 @@
     :return: True on success
     """
     # Safety in case filtering didn't occur before
-    if READY not in request['qa_signoff']:
+    if request['qa'] != READY:
         return False
 
     landers = ", ".join(request['landers'].split())
@@ -464,7 +464,7 @@
 def remove_not_ready_for_qa(api_key, token, landing_data, dry_run=False):
     """ Move to failed the cards that are not ready for QA anymore """
     reqs_ready = [req['id'] for req in landing_data
-                  if READY in req['qa_signoff']]
+                  if req['qa'] != READY]
 
     for request in get_cards_ready_for_qa(api_key, token):
         if int(request[1]) not in reqs_ready: