Phablet Tools

Code review comment for lp:~robru/phablet-tools/make-useful-again

make-useful-again
Merge into trunk

Revision history for this message

Robert Bruce Park (robru) wrote on 2015-10-14:

Ok, I tested this on silo 14 (webbrowser-app), and got the following results:

+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get install ubuntu-touch qtdeclarative5-ubuntu-ui-extras-browser-plugin qtdeclarative5-ubuntu-web-plugin webapp-container webbrowser-app --yes
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following package was automatically installed and is no longer required:
  qtdeclarative5-ubuntu-web-plugin-assets
Use 'apt-get autoremove' to remove it.
The following extra packages will be installed:
  gstreamer1.0-plugins-ugly-amr indicator-transfer
  indicator-transfer-download-manager libindicator-transfer0
  libopencore-amrnb0 libopencore-amrwb0 liboxideqt-qmlplugin liboxideqtcore0
  liboxideqtquick0 oxideqt-codecs-extra
The following NEW packages will be installed:
  gstreamer1.0-plugins-ugly-amr indicator-transfer-download-manager
  libindicator-transfer0 libopencore-amrnb0 libopencore-amrwb0
The following packages will be upgraded:
  indicator-transfer liboxideqt-qmlplugin liboxideqtcore0 liboxideqtquick0
  oxideqt-codecs-extra qtdeclarative5-ubuntu-ui-extras-browser-plugin
  qtdeclarative5-ubuntu-web-plugin ubuntu-touch webapp-container
  webbrowser-app
10 upgraded, 5 newly installed, 0 to remove and 278 not upgraded.
Need to get 24.4 MB of archives.
After this operation, 909 kB of additional disk space will be used.
Get:1 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe libopencore-amrnb0 armhf 0.1.3-2.1 [81.8 kB]
Get:2 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main liboxideqtcore0 armhf 1.9.5-0ubuntu0.15.04.1 [22.1 MB]
Get:3 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe libopencore-amrwb0 armhf 0.1.3-2.1 [41.5 kB]
Get:4 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main liboxideqt-qmlplugin armhf 1.9.5-0ubuntu0.15.04.1 [168 kB]
Get:5 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main liboxideqtquick0 armhf 1.9.5-0ubuntu0.15.04.1 [233 kB]
Get:6 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main oxideqt-codecs-extra armhf 1.9.5-0ubuntu0.15.04.1 [769 kB]
Get:7 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe gstreamer1.0-plugins-ugly-amr armhf 1.4.5-1ubuntu2 [16.5 kB]
Get:8 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main qtdeclarative5-ubuntu-ui-extras-browser-plugin armhf 0.23+15.04.20151013.1-0ubuntu1 [10.7 kB]
Get:9 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main webapp-container armhf 0.23+15.04.20151013.1-0ubuntu1 [142 kB]
Get:10 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main webbrowser-app armhf 0.23+15.04.20151013.1-0ubuntu1 [722 kB]
Get:11 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main qtdeclarative5-ubuntu-web-plugin armhf 0.23+15.04.20151013.1-0ubuntu1 [17.5 kB]
Get:12 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main libindicator-transfer0 armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [43.2 kB]
Get:13 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main indicator-transfer armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [6,754 B]
Get:14 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main indicator-transfer-download-manager armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [24.1 kB]
Get:15 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main ubuntu-touch armhf 1.221vivid14 [3,060 B]
Fetched 24.4 MB in 13s (1,872 kB/s)

So as you can see here, libindicator-transfer0, indicator-transfer, indicator-transfer-download-manager, and ubuntu-touch were mistakenly installed from stable-snapshot ppa, unrelated to silo. And, liboxideqt-qmlplugin, liboxideqtquick0, oxideqt-codecs-extra, gstreamer1.0-plugins-ugly-amr were installed from vivid archive, but it's not clear to me if those are needed by the silo or not. oxide is related to webbrowser-app.

+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get autoremove --yes
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
qtdeclarative5-ubuntu-web-plugin-assets
0 upgraded, 0 newly installed, 1 to remove and 278 not upgraded.
After this operation, 66.6 kB disk space will be freed.

The autoremove is seemingly correct in the sense that it didn't uninstall the entire world, but I'm not sure if this removal is correct or not.

Ok, I tested this on silo 14 (webbrowser-app), and got the following results:

+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get install ubuntu-touch qtdeclarative5-ubuntu-ui-extras-browser-plugin qtdeclarative5-ubuntu-web-plugin webapp-container webbrowser-app --yes
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following package was automatically installed and is no longer required:
  qtdeclarative5-ubuntu-web-plugin-assets
Use 'apt-get autoremove' to remove it.
The following extra packages will be installed:
  gstreamer1.0-plugins-ugly-amr indicator-transfer
  indicator-transfer-download-manager libindicator-transfer0
  libopencore-amrnb0 libopencore-amrwb0 liboxideqt-qmlplugin liboxideqtcore0
  liboxideqtquick0 oxideqt-codecs-extra
The following NEW packages will be installed:
  gstreamer1.0-plugins-ugly-amr indicator-transfer-download-manager
  libindicator-transfer0 libopencore-amrnb0 libopencore-amrwb0
The following packages will be upgraded:
  indicator-transfer liboxideqt-qmlplugin liboxideqtcore0 liboxideqtquick0
  oxideqt-codecs-extra qtdeclarative5-ubuntu-ui-extras-browser-plugin
  qtdeclarative5-ubuntu-web-plugin ubuntu-touch webapp-container
  webbrowser-app
10 upgraded, 5 newly installed, 0 to remove and 278 not upgraded.
Need to get 24.4 MB of archives.
After this operation, 909 kB of additional disk space will be used.
Get:1 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe libopencore-amrnb0 armhf 0.1.3-2.1 [81.8 kB]
Get:2 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main liboxideqtcore0 armhf 1.9.5-0ubuntu0.15.04.1 [22.1 MB]
Get:3 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe libopencore-amrwb0 armhf 0.1.3-2.1 [41.5 kB]
Get:4 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main liboxideqt-qmlplugin armhf 1.9.5-0ubuntu0.15.04.1 [168 kB]
Get:5 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main liboxideqtquick0 armhf 1.9.5-0ubuntu0.15.04.1 [233 kB]
Get:6 http://ports.ubuntu.com/ubuntu-ports/ vivid-updates/main oxideqt-codecs-extra armhf 1.9.5-0ubuntu0.15.04.1 [769 kB]
Get:7 http://ports.ubuntu.com/ubuntu-ports/ vivid/universe gstreamer1.0-plugins-ugly-amr armhf 1.4.5-1ubuntu2 [16.5 kB]
Get:8 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main qtdeclarative5-ubuntu-ui-extras-browser-plugin armhf 0.23+15.04.20151013.1-0ubuntu1 [10.7 kB]
Get:9 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main webapp-container armhf 0.23+15.04.20151013.1-0ubuntu1 [142 kB]
Get:10 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main webbrowser-app armhf 0.23+15.04.20151013.1-0ubuntu1 [722 kB]
Get:11 http://ppa.launchpad.net/ci-train-ppa-service/landing-014/ubuntu/ vivid/main qtdeclarative5-ubuntu-web-plugin armhf 0.23+15.04.20151013.1-0ubuntu1 [17.5 kB]
Get:12 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main libindicator-transfer0 armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [43.2 kB]
Get:13 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main indicator-transfer armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [6,754 B]
Get:14 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main indicator-transfer-download-manager armhf 0.2+15.04.20150929.is.0.2+15.10.20150819-0ubuntu1 [24.1 kB]
Get:15 http://ppa.launchpad.net/ci-train-ppa-service/stable-snapshot/ubuntu/ vivid/main ubuntu-touch armhf 1.221vivid14 [3,060 B]
Fetched 24.4 MB in 13s (1,872 kB/s)

+ adb shell SUDO_ASKPASS=/tmp/askpass.sh sudo -A apt-get autoremove --yes
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following packages will be REMOVED:
  qtdeclarative5-ubuntu-web-plugin-assets
0 upgraded, 0 newly installed, 1 to remove and 278 not upgraded.
After this operation, 66.6 kB disk space will be freed.

The autoremove is seemingly correct in the sense that it didn't uninstall the entire world, but I'm not sure if this removal is correct or not.

« Back to merge proposal