Merge lp:~robru/phablet-tools/dont-delete-silos into lp:phablet-tools

Proposed by Robert Bruce Park
Status: Merged
Approved by: Michał Sawicz
Approved revision: 286
Merged at revision: 286
Proposed branch: lp:~robru/phablet-tools/dont-delete-silos
Merge into: lp:phablet-tools
Diff against target: 21 lines (+0/-4)
1 file modified
citrain (+0/-4)
To merge this branch: bzr merge lp:~robru/phablet-tools/dont-delete-silos
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Robert Bruce Park (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Sergio Schvezov Approve
Review via email: mp+224340@code.launchpad.net

Commit message

Don't delete PPAs because this breaks ppa-purge. (LP: #1333184)

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

looks good to me; we can top approve once someone acks on testing

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Haha, no Jenkins, you can't pep8 my shell script! Looks like trunk is a little sloppy right now ;-)

Revision history for this message
Robert Bruce Park (robru) wrote :

I tested this myself, does that count?

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

Yes please!

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

Tested, works fine.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'citrain'
--- citrain 2014-05-28 12:56:04 +0000
+++ citrain 2014-06-24 18:12:38 +0000
@@ -64,8 +64,6 @@
64 wget -qO- $HTTP/$SILO/$SOURCES \64 wget -qO- $HTTP/$SILO/$SOURCES \
65 | perl -ne 's/,//g; s/^Binary: // && print' \65 | perl -ne 's/,//g; s/^Binary: // && print' \
66 | xargs --verbose sudo apt-get install --yes66 | xargs --verbose sudo apt-get install --yes
67 sudo rm -rf /etc/apt/sources.list.d/ci-train*
68 sudo apt-get update -qq
69 ;;67 ;;
7068
71 device-install)69 device-install)
@@ -81,8 +79,6 @@
81 sudo add-apt-repository $PPA/$SILO79 sudo add-apt-repository $PPA/$SILO
82 sudo apt-get update -qq80 sudo apt-get update -qq
83 sudo apt-get dist-upgrade --yes81 sudo apt-get dist-upgrade --yes
84 sudo rm -rf /etc/apt/sources.list.d/ci-train*
85 sudo apt-get update -qq
86 ;;82 ;;
8783
88 device-upgrade)84 device-upgrade)

Subscribers

People subscribed via source and target branches