Code review comment for lp:~robru/phablet-tools/citrain-on-rtm

On Thu, Sep 25, 2014 at 2:22 AM, ♫ Robert Bruce Park ♫ <
<email address hidden>> wrote:

> > Why not pass --ppa=$PPA/$DISTRO/$SILO to phablet-config writable-image
> instead of calling that seperately?
>
> Well, I didn't check, but I was just assuming that phablet-config didn't
> support the $PPA/$DISTRO/$SILO syntax for PPAs, so I was working around
> that.
>
> Even if phablet-config really does work on RTM, it's just calling
> add-apt-repository anyway. What benefit do we get from going through a
> middleman?
>
phablet-config calls add-apt-repository so basically you're just avoiding
code duplication where possible - it's sound practice

>
> > I don't think --force-yes is necessary any more and might even be a
> little unsafe since we should be dealing with a PPA whose key we have
> received already.
>
> Yeah I can fix that tomorrow, EOD now!
> --
>
> https://code.launchpad.net/~robru/phablet-tools/citrain-on-rtm/+merge/235069
> You are reviewing the proposed merge of
> lp:~robru/phablet-tools/citrain-on-rtm into lp:phablet-tools.
>