Code review comment for lp:~robru/phablet-tools/citrain-on-rtm

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

> 1. Cyphermox suggested that even once add-apt-repository gets fixed in rtm, it
> would attempt to add distro series as "utopic" even though that's not valid.
> So the only way to get the distro and series correct is to write the full deb
> line manually.

I keep hearing mixed messages on that - cjwatson told me earlier today he thought it was possible and just had to confer with mvo over the exact right way to do it. Keep an eye on https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu-rtm/landing-017 to see what happens with it.
>
> You can pass the full deb line to add-apt-repository, but if you do, it adds
> the line to /etc/apt/sources.list rather than to sources.list.d, which breaks
> the logic of "set sources.list to /dev/null to isolate the silo contents" hack
> below.
>
> So I realized, since I'm reduced to writing my own deb line anyway, i might as
> well just make my own sources.list and reference it myself.
>
> 2. Because phablet-config just wraps add-apt-repository which I'm not
> convinced can be fixed for rtm, due to what cyphermox said about it.
>
> 3. I dunno, will it break other tools? Patches welcome.

Yes, apt-get install and dist-upgrade will fail unless they have --force-yes specified, which many tools in phablet-tools don't. I could submit a patch but it's as simple as adding:

apt-key adv --keyserver keyserver.ubuntu.com --recv-keys ECF1204C # <- the ci-train-ppa-service key

prior to running apt-get update

« Back to merge proposal