Code review comment for lp:~robru/gwibber/locked-login-refactor

Revision history for this message
Barry Warsaw (barry) wrote :

On Oct 09, 2012, at 08:03 PM, Robert Bruce Park wrote:

>Barry, I split this into a separate mp just for you. No rush, Facebook won't
>be ready today anyway. ;-)

This looks great, and I'm ready to merge it, but I have one question.

> - data = get_json(SELF_URL.format(access_token=token)) or {}

I see this pattern a lot, but I wonder why. Is it expected that get_json()
would return a false value that *wasn't* an empty dictionary?

I'm very tempted to take out the "or {}" unless there's a concrete reason
to add it back (read: failing test :).

« Back to merge proposal