Merge lp:~robru/friends/fix-autopkgtest into lp:friends

Proposed by Robert Bruce Park
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 229
Merged at revision: 229
Proposed branch: lp:~robru/friends/fix-autopkgtest
Merge into: lp:friends
Diff against target: 42 lines (+9/-3)
2 files modified
friends/tests/mocks.py (+2/-2)
friends/tests/test_facebook.py (+7/-1)
To merge this branch: bzr merge lp:~robru/friends/fix-autopkgtest
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Robert Bruce Park Approve
Review via email: mp+177487@code.launchpad.net

Commit message

Fix autopkgtest failures.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Martin Pitt (pitti) wrote :

I confirm that this fixes the autopkgtest, thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'friends/tests/mocks.py'
--- friends/tests/mocks.py 2013-04-17 06:13:49 +0000
+++ friends/tests/mocks.py 2013-07-29 22:12:26 +0000
@@ -333,7 +333,7 @@
333 pass333 pass
334334
335 def get_uid(self):335 def get_uid(self):
336 return 'test-source-uid'336 return self.name
337337
338 def get_extension(self, extension_name):338 def get_extension(self, extension_name):
339 return EDSExtension()339 return EDSExtension()
@@ -360,5 +360,5 @@
360360
361 def ref_source(self, src_uid):361 def ref_source(self, src_uid):
362 s1 = EDSSource(None, None)362 s1 = EDSSource(None, None)
363 s1.set_display_name('test-facebook-contacts')363 s1.set_display_name('friends-testsuite-contacts')
364 return s1364 return s1
365365
=== modified file 'friends/tests/test_facebook.py'
--- friends/tests/test_facebook.py 2013-07-23 08:17:16 +0000
+++ friends/tests/test_facebook.py 2013-07-29 22:12:26 +0000
@@ -590,11 +590,17 @@
590590
591 @mock.patch('gi.repository.EBook.BookClient.connect_sync',591 @mock.patch('gi.repository.EBook.BookClient.connect_sync',
592 return_value=EDSBookClientMock())592 return_value=EDSBookClientMock())
593 @mock.patch('gi.repository.EDataServer.SourceRegistry.new_sync',
594 return_value=EDSRegistry())
593 def test_successful_previously_stored_contact(self, *mocks):595 def test_successful_previously_stored_contact(self, *mocks):
594 result = self.protocol._previously_stored_contact('11111')596 result = self.protocol._previously_stored_contact('11111')
595 self.assertEqual(result, True)597 self.assertEqual(result, True)
596598
597 def test_first_run_prepare_eds_connections(self):599 @mock.patch('gi.repository.EBook.BookClient.connect_sync',
600 return_value=EDSBookClientMock())
601 @mock.patch('gi.repository.EDataServer.SourceRegistry.new_sync',
602 return_value=EDSRegistry())
603 def test_first_run_prepare_eds_connections(self, *mocks):
598 self.protocol._name = 'testsuite'604 self.protocol._name = 'testsuite'
599 self.assertIsNone(self.protocol._address_book_name)605 self.assertIsNone(self.protocol._address_book_name)
600 self.assertIsNone(self.protocol._eds_source_registry)606 self.assertIsNone(self.protocol._eds_source_registry)

Subscribers

People subscribed via source and target branches