Merge lp:~robru/errors/show-graph-years into lp:errors

Proposed by Robert Bruce Park
Status: Merged
Merged at revision: 565
Proposed branch: lp:~robru/errors/show-graph-years
Merge into: lp:errors
Diff against target: 24 lines (+3/-3)
1 file modified
errors/static/js/mean_time_between_failures.js (+3/-3)
To merge this branch: bzr merge lp:~robru/errors/show-graph-years
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+289438@code.launchpad.net

Description of the change

Show years in graph X axis.

To post a comment you must log in.
lp:~robru/errors/show-graph-years updated
565. By Robert Bruce Park

Append year beneath day of month.

566. By Robert Bruce Park

Use two lines instead of one.

Revision history for this message
Brian Murray (brian-murray) wrote :

Tested using my errors server that points at the production database, looks good! Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'errors/static/js/mean_time_between_failures.js'
2--- errors/static/js/mean_time_between_failures.js 2015-10-28 19:00:28 +0000
3+++ errors/static/js/mean_time_between_failures.js 2016-03-17 22:42:02 +0000
4@@ -77,7 +77,7 @@
5 chart.margin({top: 10, right: 5, bottom: 40, left: 30});
6 chart.xAxis.showMaxMin(false);
7 chart.xAxis.tickValues(ticks);
8- chart.xAxis.tickFormat(d3.time.format('%b'));
9+ chart.xAxis.tickFormat(d3.time.format('%b %e'));
10 chart.yAxis.tickFormat(y_axis_tick_format);
11 chart.forceY([0]); // including zero means starting at zero
12 chart.x(function(d) { return new Date(d.x); })
13@@ -165,9 +165,9 @@
14 .attr('transform',
15 'translate(-2,-' + chartTop + ')rotate(-90)');
16
17- /* Milestone day of the month */
18+ /* Milestone year */
19 g.append('text')
20- .text(d3.time.format('%e')(d))
21+ .text(d3.time.format('%Y')(d))
22 .attr('text-anchor', 'middle')
23 .attr('transform', 'translate(0,29)');
24 });

Subscribers

People subscribed via source and target branches