Code review comment for lp:~robru/cupstream2distro/set-ppa-description

Revision history for this message
Robert Bruce Park (robru) wrote :

Thanks Colin, I don't think it's an issue because ".ppa = ..." is only ever called once in one place, and also the ppa is not something that can change during the life of the SiloState object (the train isn't a long-running process, it starts up with each jenkins job and then exits when done). So it's really a non issue (in fact I should drop the setter entirely, but I'll clean that kind of thing up later)

« Back to merge proposal