Code review comment for lp:~robru/cupstream2distro/fix-locking

Revision history for this message
Robert Bruce Park (robru) wrote :

On Oct 28, 2015 8:36 AM, "Barry Warsaw" <email address hidden> wrote:
> How confident are you that there aren't corner cases which would deadlock
the
> silo?

Very confident, because this isn't long running code. Any error or
exception will cause the process to exit, which as far as i can tell,
guarantees the file handle be closed and the lock released.

Also NFS mounts aren't a concern but I'll take a look at flufl in a sec.

« Back to merge proposal