Merge lp:stock-ticker-mobile-app/stable into lp:stock-ticker-mobile-app

[Robert Steckroth]

Design fixes and autopilot tests added

Design fixes and autopilot tests added.

[Robert Steckroth (robertsteckroth)]

Looking for sucessfull autopilot tests.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~robertsteckroth/stock-ticker-mobile-app/Stock-Ticker/+merge/174997/+edit-commit-message

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:10
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robertsteckroth/stock-ticker-mobile-app/Stock-Ticker/+merge/174997/+edit-commit-message

http://91.189.93.70:8080/job/stock-ticker-mobile-app-ci/3/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/stock-ticker-mobile-app-precise-amd64-ci/2
    SUCCESS: http://91.189.93.70:8080/job/stock-ticker-mobile-app-quantal-amd64-ci/3
    SUCCESS: http://91.189.93.70:8080/job/stock-ticker-mobile-app-raring-amd64-ci/3
    SUCCESS: http://91.189.93.70:8080/job/stock-ticker-mobile-app-saucy-amd64-ci/2

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/stock-ticker-mobile-app-ci/3/rebuild

review: Needs Fixing (continuous-integration)

[David Planella (dpm)]

Robert,

Looking at the diff, I can only see this one-line change:

+// console.log("["+applicationName+"] "+message)

It strikes me that it's a really small change that could either be included as part of a bigger branch and might not deserve a full merge proposal/review process at this point. It's totally ok if that was your intention, but just checking: is this the only change you wanted to submit for review?

review: Needs Information

[Robert Steckroth (robertsteckroth)]

No that was an after-thought. The merge with truck is rather large.

On Tue, Jul 16, 2013 at 9:12 AM, David Planella
<email address hidden>wrote:

> Review: Needs Information
>
> Robert,
>
> Looking at the diff, I can only see this one-line change:
>
> +// console.log("["+applicationName+"] "+message)
>
> It strikes me that it's a really small change that could either be
> included as part of a bigger branch and might not deserve a full merge
> proposal/review process at this point. It's totally ok if that was your
> intention, but just checking: is this the only change you wanted to submit
> for review?
> --
>
> https://code.launchpad.net/~robertsteckroth/stock-ticker-mobile-app/Stock-Ticker/+merge/174997
> You are the owner of lp:stock-ticker-mobile-app/stable.
>

--
Bust0ut, Surgemcgee: Systems/Web/Software Engineer

"Freedom is empowered by those without power" - Robert Edward Steckroth II
"Injustice, regarding the internet, is fashioned through laws and
enforcement" - Robert Edward Steckroth II
"Understated phrases spawn from unpopular quotes" - Robert Edward Steckroth
II

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'Stock_Ticker.qml'
--- Stock_Ticker.qml	2013-07-16 12:36:53 +0000
+++ Stock_Ticker.qml	2013-07-16 12:47:24 +0000
@@ -48,7 +48,7 @@
     property string quoteParams: "?f=sabl1vpghojkc8dre7j1n&s="
 
     function log(message) {
-         console.log("["+applicationName+"] "+message)
+//         console.log("["+applicationName+"] "+message)
     }
 
     Component.onCompleted: {