Code review comment for lp:~roberto-v/openobject-italia/7.0

> Following this MP
> https://code.launchpad.net/~roberto-v/account-
> payment/adding_account_vat_on_payment_7/+merge/205723
> maybe better if we use fiscal positions for withholding taxes too?

Depends... :)

After discussing this in my shop, the reasoning is as follows:

- VAT on Payment gives a financial advantage, so it is always used where applicable by law; linking it to fiscal position seems the best bet, because it depends on law. After I set it to True, I have the best possible advantage. Only in rare cases, I will manually set it to False.

- Withholding Taxes is something you have to do with some parties, but it doesn't give any financial advantage; normally companies prefer to avoid it because it implies more accounting work; linking it to a supplier seems the best choice because you want to use it as little as possible. I don't see any advantages on linking it to fiscal position: it will quite always be False and you still have to set it manually to True on every supplier you need to.

However, if you have valid reasons to do it differently let me know and we may discuss a solution.