Code review comment for lp:~roberto-v/account-payment/adding_account_vat_on_payment_7

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Roberto, thanks for your changes.
I think using fiscal positions is a better choice.

Some remarks:
line 39: 'for partner_id in partner_obj.browse(cr, uid, [partner_id])' can just be 'partner = partner_obj.browse(cr, uid, partner_id, context=context)'
line 41: if 'property_account_position' was not set, partner.property_account_position.default_has_vat_on_payment would raise exception
line 89, I think the _defaults is unnecessary

review: Needs Fixing

« Back to merge proposal