Code review comment for ~robertliu/snappy-hwe-snaps/+git/modme-manager:conditional-restart-service
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks, this looks really nice. However the "sleep 1" between writing the properties and restarting MM should not be really necessary, and I would be surprised if it is because of the file being written late. Note also that for the network-manager snap this sleep is not necessary.
Could you maybe find the service state and the journal when things fail? That would help us find the cause. Maybe the problem is too fast re-starts or similar.