Mir

Code review comment for lp:~robertcarr/mir/weakify-event-filters

  1. weakify-event-filters
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

On 24/04/13 11:49, Alan Griffiths wrote:
> Review: Approve
>
> I agree, writing the loop to do two things makes it more complicated.
>
> I'd be tempted to use the erase idiom first, then the loop:
>
> filters.erase(
> std::remove_if(filters.begin(), filters.end(), [](EventFilterVector::value_type const& f) {return

Or even "EventFilterVector::const_reference f"

--
Alan Griffiths +44 (0)798 9938 758
Octopull Ltd http://www.octopull.co.uk/

« Back to merge proposal