Mir

Code review comment for lp:~robertcarr/mir/socket-messenger-race

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

void mfd::ProtobufMessageProcessor::send_response(
...
133 -
134 - sender->send(send_response_buffer);
135 + try
136 + {
137 + sender->send(send_response_buffer, fd_sets);
138 + }
139 + catch (std::exception const& error)
140 + {
141 + report->exception_handled(display_server.get(),
142 + id, error);
143 + }
144 }

Exceptions should not be eaten here. They should propagate to ProtobufMessageProcessor::dispatch() - which handles them correctly.

review: Needs Fixing

« Back to merge proposal