Mir

Code review comment for lp:~robertcarr/mir/receive-input-in-client

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

2667 - auto surface = std::make_shared<MirSurface> (connection.get(),
2668 - *client_comm_channel,
2669 - logger,
2670 - mock_buffer_factory,
2671 - params,
2672 - &empty_callback,
2673 - nullptr);
2674 + auto surface = std::make_shared<MirSurface> (connection.get(), *client_comm_channel, logger, mock_buffer_factory, input_platform, params, nullptr, &empty_callback, (void*) NULL);

Using "(void*) NULL" in place of "nullptr" isn't an improvement.

review: Needs Fixing

« Back to merge proposal