Mir

Code review comment for lp:~robertcarr/mir/notify-surface-destruction

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'd prefer having surface_created() and surface_destroyed() so they're more symmetrical. In that case you'd remove the surface from the container and destroy it after passing it to the listener. But it's not major and it depends on how you're consuming these events.

Other than the missing file, this seems OK.

review: Approve

« Back to merge proposal