Mir

Code review comment for lp:~robertcarr/mir/input-lttng

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> Unfortunately I am unable to make lttng work (with both the existing message processor
> report and my new report) so I haven't been able to confirm the output

Did you follow the instructions in HACKING.md (especially the LD_PRELOAD note)?

984 +protected:
985 + InputReport() = default;
986 +
987 +private:
988 + InputReport(InputReport const&) = delete;
989 + InputReport& operator=(InputReport const&) = delete;

The preferred form is to make the deleted copy constructor and assignment operator protected too, for compactness.

1043 + protected:
1044 + NullInputReport(NullInputReport const&) = delete;
1045 + NullInputReport& operator=(NullInputReport const&) = delete;

1088 +protected:
1089 + InputReport(InputReport const&) = delete;
1090 + InputReport& operator=(InputReport const&) = delete;

There is no need to repeat the deletions, they are enforced by the base class.

review: Needs Fixing

« Back to merge proposal