Mir

Code review comment for lp:~robertcarr/mir/implement-client-credentials

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

272 + if (!session_authorizer->connection_is_allowed(session->client_pid()))
273 + {
274 + start_accept();
275 + return;
276 + }
277 +
278 connected_sessions->add(session);
279 -
280 session->read_next_message();
281 }
282 start_accept();

        if (session_authorizer->connection_is_allowed(session->client_pid()))
        {
            connected_sessions->add(session);
            session->read_next_message();
        }
    }
    start_accept();

~~~~

368 -
369 +
...
377 -
378 +

Introduces trailing whitespace

~~~~

392 + optional int32 client_pid = 2;

Not used

~~~~

712 - struct sockaddr_un remote;
713 +/* struct sockaddr_un remote;
...
721 - close(sockfd);
722 + close(sockfd);*/

Not suitable for trunk

review: Needs Fixing

« Back to merge proposal