ok! the abstraction is looking much better. The android platform returning a null is ok. Overall this looks good to me, a few minor things:
platform.h mir_native_display() let's make this name indicate more that this is "inprocess egl"
android_platform.cpp test_display_info.cpp <others> C-style cast (although if its tough to get around because these are EGL types, i suppose its ok)
display_server.cpp addition of tab whitespace after member variable
native_display.h I don't see what's driving the change to void*
mesa_native_display_container.cpp we can considate the extern "C" with the one already in the file pretty easily
mesa_native_display.cpp we use new/raw ptrs instead of std::shared_ptr
« Back to merge proposal
ok! the abstraction is looking much better. The android platform returning a null is ok. Overall this looks good to me, a few minor things:
platform.h display( ) let's make this name indicate more that this is "inprocess egl"
mir_native_
android_ platform. cpp info.cpp
test_display_
<others>
C-style cast (although if its tough to get around because these are EGL types, i suppose its ok)
display_server.cpp
addition of tab whitespace after member variable
native_display.h
I don't see what's driving the change to void*
mesa_native_ display_ container. cpp
we can considate the extern "C" with the one already in the file pretty easily
mesa_native_ display. cpp
we use new/raw ptrs instead of std::shared_ptr