Code review comment for lp:~robertcarr/mir/enable-inprocess-egl

> Kevin:
> >> We're going to need some sort of platform abstraction for this I'd
> imagine... something like a mgeglm:create_native_display() (except in >> a
> platform independent namespace) that the inprocess clients can use without
> having to worry about mesa/android differences. Should we />> make a work item
> for this?
>
> I think maybe just a bug is fine?

Well, seems like a good time to head off a bug :)

include/server/mir/graphics/egl/mesa_native_display.h
We have a mir::graphics::egl::mesa::create_native_display that takes the Platform as an argument... seems more appropriate that we add a "create_native_display" in mg::Platform that calls mgeglm::create_native_display. This would make the example platform-independent too

>
> >> This might be because i'm not steeped in mesa terminology, but
> "MesaNativeDisplay" doesn't give me a hint as to what this is doing. (I
> >>could argue that the framebuffer is a native display too!) Maybe
> RenderTargetWindow? MesaInternalWindowType?
>
> Would it help if it were called MesaEGLNativeDisplay? I only chose to avoid
> this because of redundancy with the namespace. But redundancy isn't always
> bad.
I'm not too stuck on this one, I suppose we can leave it as it is

>
> >> related to this... src/server/graphics/android and src/server/graphics/gbm
> are both platforms... egl isn't really a platform in this
> >> sense. maybe mesa_native_display.cpp should go in src/server/graphics/gbm
> and we can get at it for mesa inprocess clients via the include/>>
> server/mir/graphics/platform.h abstraction?
>
> My thought here was that Mesa isn't really part of the "GBM" platform so to
> speak, so perhaps after android in server support lands there is
> graphics/egl/android/android_native_display.cpp and
> graphics/egl/mesa/mesa_native_display.cpp

Could we just model these as a different displays? I'm beginning to think that we do need one folder for displays that are not necessarily tied to a platform (eg, an SDL display that Elenimaria was looking at, or one for mir-as-mir-client, or one for this). I am still favoring this being in the gbm platform folder, as we can't really separate mesa from gbm so they're all one logical platform, even if mesa and gbm are distinct pieces when working on that platform