Mir

Code review comment for lp:~robertcarr/mir/dev-package-depends-on-boost

Revision history for this message
Robert Ancell (robert-ancell) wrote :

There's more that just program options required:

$ grep boost include/server/ -r | grep '#include'
include/server/mir/asio_main_loop.h:#include <boost/asio.hpp>
include/server/mir/compositor/buffer_swapper_spin.h:#include <boost/throw_exception.hpp>
include/server/mir/options/program_option.h:#include <boost/program_options/variables_map.hpp>
include/server/mir/options/program_option.h:#include <boost/program_options/options_description.hpp>

$ dpkg --search /usr/include/boost/asio.hpp
libboost1.53-dev: /usr/include/boost/asio.hpp
$ dpkg --search /usr/include/boost/program_options.hpp
libboost1.53-dev: /usr/include/boost/program_options.hpp
$ dpkg --search /usr/include/boost/throw_exception.hpp
libboost1.53-dev: /usr/include/boost/throw_exception.hpp

So we should probably just include libboost-dev and this will cover them all (and any future boost dependencies we add)

review: Needs Fixing

« Back to merge proposal