Mir

Code review comment for lp:~robertcarr/mir/dedupe-null-input-managers

  1. dedupe-null-input-managers
  2. Merge into trunk
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> This does not need to be virtual but it doesn't hurt:
> virtual ~NullInputManager() {}

It is virtual regardless of how it is written, but it doesn't need to be written (and could be noexcept).

> Also, isn't this server/testing code? If so then the license looks wrong: "GNU
> Lesser General Public License". It should probably be GPL for pure server
> components.

It is in the server .so, so LGPL is correct.

review: Approve

« Back to merge proposal