Unity Greeter

Merge lp:~robert-ancell/unity-greeter/no-warnings into lp:unity-greeter

  1. no-warnings
  2. Merge into trunk
Proposed by Robert Ancell
Status: Merged
Approved by: Michael Terry
Approved revision: 988
Merged at revision: 992
Proposed branch: lp:~robert-ancell/unity-greeter/no-warnings
Merge into: lp:unity-greeter
Diff against target: 25 lines (+2/-2)
2 files modified
src/Makefile.am (+1/-1)
tests/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~robert-ancell/unity-greeter/no-warnings
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+191732@code.launchpad.net

Commit message

Disable C warnings - Vala generates warnings that can't be fixed and generally aren't a problem

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:988
http://jenkins.qa.ubuntu.com/job/unity-greeter-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-greeter-saucy-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-greeter-saucy-armhf-ci/7

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity-greeter-ci/12/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Yup, makes sense. I do the same thing in deja-dup.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2013-02-13 20:46:08 +0000
+++ src/Makefile.am 2013-10-17 22:10:37 +0000
@@ -34,7 +34,7 @@
3434
35unity_greeter_CFLAGS = \35unity_greeter_CFLAGS = \
36 $(UNITY_GREETER_CFLAGS) \36 $(UNITY_GREETER_CFLAGS) \
37 $(WARN_CFLAGS) \37 -w \
38 -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \38 -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \
39 -DLOCALEDIR=\""$(localedir)"\" \39 -DLOCALEDIR=\""$(localedir)"\" \
40 -DVERSION=\"$(VERSION)\" \40 -DVERSION=\"$(VERSION)\" \
4141
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2013-03-15 18:49:28 +0000
+++ tests/Makefile.am 2013-10-17 22:10:37 +0000
@@ -39,7 +39,7 @@
3939
40unity_greeter_test_CFLAGS = \40unity_greeter_test_CFLAGS = \
41 $(UNITY_GREETER_CFLAGS) \41 $(UNITY_GREETER_CFLAGS) \
42 $(WARN_CFLAGS) \42 -w \
43 -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \43 -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \
44 -DLOCALEDIR=\""$(localedir)"\" \44 -DLOCALEDIR=\""$(localedir)"\" \
45 -DVERSION=\"$(VERSION)\" \45 -DVERSION=\"$(VERSION)\" \

Subscribers

People subscribed via source and target branches