Unity Control Center

Code review comment for lp:~robert-ancell/unity-control-center/show-login-name

  1. show-login-name
  2. Merge into trunk
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for working on that Robert!

The glib API [1] suggests to use g_settings_schema_source_lookup () rather than the loop approch, can you change that?
(https://developer.gnome.org/gio/unstable/gio-GSettingsSchema-GSettingsSchemaSource.html#g-settings-schema-source-lookup)

Otherwise code/behaviour looks fine

[1] https://developer.gnome.org/gio/unstable/GSettings.html#g-settings-list-schemas

review: Needs Fixing

« Back to merge proposal