Mir

Code review comment for lp:~robert-ancell/mir/server-headers

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It works well. Stylistically I have no immediate complaint. And bug 1136938 is indeed fixed.

However the list of "server headers" is very long. Some headers such as:
    ${CMAKE_SOURCE_DIR}/include/server/mir/graphics/gl_renderer.h
should not be installed as part of the server (that one is for example code and tests only). There will probably be other such headers that should not be in that list so please re-evaluate the minimum set of headers you really need right now.

review: Needs Fixing

« Back to merge proposal