Mir

Code review comment for lp:~robert-ancell/mir/alt-ctrl-backspace

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > In https://code.launchpad.net/~afrantzis/mir/multimonitor-
> > examples/+merge/178039 (not merged yet) I have added a base
> > mir::examples::ServerConfiguration which all the demo servers and standalone
> > programs use. We could put the filters there.
...
> Sounds good!

The above has landed, so is this the plan?

It will address the duplication of code.

~~~~

18 +static mir::DisplayServer *server_ptr{nullptr};

I'm not a fan of mutable static data, and this seems unnecessary as quit_filter can be captured by the init lambda and could have set_server()/server_ptr members.

review: Needs Fixing

« Back to merge proposal