Code review comment for lp:~robert-ancell/mir/abstract-session-container
Revision history for this message
| Robert Ancell (robert-ancell) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> well, looks good to me.
>
> 83 + virtual ~SessionContainer() {};
> could be virtual ~SessionContainer() = default; ,which gives the stronger
> noexcept guarantee. (some of our classes have this, some don't but I think
> we're moving more towards this convention)
I copied ServerConfiguration here in doing it this way. When I originally had the default destructor it stops the mock SessionContainer classes from working (not sure why).