Merge lp:~robert-ancell/lightdm/test-mode-broken into lp:lightdm

Proposed by Robert Ancell
Status: Merged
Approved by: Robert Ancell
Approved revision: 1791
Merged at revision: 1791
Proposed branch: lp:~robert-ancell/lightdm/test-mode-broken
Merge into: lp:lightdm
Diff against target: 46 lines (+14/-4)
2 files modified
src/seat.c (+12/-4)
src/session.c (+2/-0)
To merge this branch: bzr merge lp:~robert-ancell/lightdm/test-mode-broken
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Ancell Approve
Review via email: mp+186560@code.launchpad.net

Commit message

Fix test-mode not working, don't try and run the greeter as the greeter user

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/seat.c'
--- src/seat.c 2013-09-09 03:24:00 +0000
+++ src/seat.c 2013-09-19 15:29:33 +0000
@@ -1050,7 +1050,6 @@
1050 gchar *sessions_dir, **argv;1050 gchar *sessions_dir, **argv;
1051 SessionConfig *session_config;1051 SessionConfig *session_config;
1052 Greeter *greeter_session;1052 Greeter *greeter_session;
1053 gchar *greeter_user;
1054 const gchar *greeter_wrapper;1053 const gchar *greeter_wrapper;
10551054
1056 l_debug (seat, "Creating greeter session");1055 l_debug (seat, "Creating greeter session");
@@ -1081,9 +1080,18 @@
1081 set_session_env (SESSION (greeter_session));1080 set_session_env (SESSION (greeter_session));
10821081
1083 session_set_pam_service (SESSION (greeter_session), GREETER_SERVICE);1082 session_set_pam_service (SESSION (greeter_session), GREETER_SERVICE);
1084 greeter_user = config_get_string (config_get_instance (), "LightDM", "greeter-user");1083 if (getuid () == 0)
1085 session_set_username (SESSION (greeter_session), greeter_user);1084 {
1086 g_free (greeter_user);1085 gchar *greeter_user;
1086 greeter_user = config_get_string (config_get_instance (), "LightDM", "greeter-user");
1087 session_set_username (SESSION (greeter_session), greeter_user);
1088 g_free (greeter_user);
1089 }
1090 else
1091 {
1092 /* In test mode run the greeter as ourself */
1093 session_set_username (SESSION (greeter_session), user_get_name (accounts_get_current_user ()));
1094 }
1087 session_set_argv (SESSION (greeter_session), argv);1095 session_set_argv (SESSION (greeter_session), argv);
1088 g_strfreev (argv);1096 g_strfreev (argv);
10891097
10901098
=== modified file 'src/session.c'
--- src/session.c 2013-08-24 05:28:19 +0000
+++ src/session.c 2013-09-19 15:29:33 +0000
@@ -758,6 +758,8 @@
758 else758 else
759 x_authority_filename = g_build_filename (user_get_home_directory (session_get_user (session)), ".Xauthority", NULL);759 x_authority_filename = g_build_filename (user_get_home_directory (session_get_user (session)), ".Xauthority", NULL);
760760
761 if (session->priv->log_filename)
762 l_debug (session, "Logging to %s", session->priv->log_filename);
761 write_string (session, session->priv->log_filename);763 write_string (session, session->priv->log_filename);
762 write_string (session, session->priv->tty);764 write_string (session, session->priv->tty);
763 write_string (session, x_authority_filename);765 write_string (session, x_authority_filename);

Subscribers

People subscribed via source and target branches