Merge lp:~robert-ancell/indicator-sound/unity-control-center2 into lp:indicator-sound/14.04

Proposed by Robert Ancell
Status: Merged
Approved by: Ted Gould
Approved revision: 409
Merged at revision: 408
Proposed branch: lp:~robert-ancell/indicator-sound/unity-control-center2
Merge into: lp:indicator-sound/14.04
Diff against target: 30 lines (+7/-2)
2 files modified
debian/control (+1/-1)
src/service.vala (+6/-1)
To merge this branch: bzr merge lp:~robert-ancell/indicator-sound/unity-control-center2
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+201132@code.launchpad.net

Commit message

Use unity-control-center if it is available

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
408. By Robert Ancell

Recommend unity-control-center before gnome-control-center

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
409. By Robert Ancell

Only run unity-control-center under unity

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-11-18 14:40:22 +0000
+++ debian/control 2014-01-21 21:33:01 +0000
@@ -31,7 +31,7 @@
31Depends: ${shlibs:Depends},31Depends: ${shlibs:Depends},
32 ${misc:Depends},32 ${misc:Depends},
33 pulseaudio,33 pulseaudio,
34Recommends: gnome-control-center | ubuntu-system-settings,34Recommends: unity-control-center | gnome-control-center | ubuntu-system-settings,
35Description: System sound indicator.35Description: System sound indicator.
36 System sound indicator which provides easy control of the PulseAudio sound 36 System sound indicator which provides easy control of the PulseAudio sound
37 daemon.37 daemon.
3838
=== modified file 'src/service.vala'
--- src/service.vala 2014-01-15 15:32:51 +0000
+++ src/service.vala 2014-01-21 21:33:01 +0000
@@ -124,7 +124,12 @@
124 if (env == "xubuntu" || env == "ubuntustudio")124 if (env == "xubuntu" || env == "ubuntustudio")
125 cmd = "pavucontrol";125 cmd = "pavucontrol";
126 else126 else
127 cmd = "gnome-control-center sound";127 {
128 if (Environment.get_variable ("XDG_CURRENT_DESKTOP") == "Unity" && Environment.find_program_in_path ("unity-control-center") != null)
129 cmd = "unity-control-center sound";
130 else
131 cmd = "gnome-control-center sound";
132 }
128133
129 try {134 try {
130 Process.spawn_command_line_async (cmd);135 Process.spawn_command_line_async (cmd);

Subscribers

People subscribed via source and target branches