Merge lp:~robert-ancell/indicator-messages/has-messages into lp:indicator-messages

Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 457
Merged at revision: 457
Proposed branch: lp:~robert-ancell/indicator-messages/has-messages
Merge into: lp:indicator-messages
Diff against target: 43 lines (+9/-6)
2 files modified
src/im-accounts-service.c (+3/-3)
tests/accounts-service-mock.h (+6/-3)
To merge this branch: bzr merge lp:~robert-ancell/indicator-messages/has-messages
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+355127@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/im-accounts-service.c'
--- src/im-accounts-service.c 2014-10-07 02:23:31 +0000
+++ src/im-accounts-service.c 2018-09-17 09:48:33 +0000
@@ -189,9 +189,9 @@
189 g_dbus_connection_call(g_dbus_proxy_get_connection(priv->touch_settings),189 g_dbus_connection_call(g_dbus_proxy_get_connection(priv->touch_settings),
190 g_dbus_proxy_get_name(priv->touch_settings),190 g_dbus_proxy_get_name(priv->touch_settings),
191 g_dbus_proxy_get_object_path(priv->touch_settings),191 g_dbus_proxy_get_object_path(priv->touch_settings),
192 "org.freedesktop.Accounts.User",192 "org.freedesktop.DBus.Properties",
193 "SetXHasMessages",193 "Set",
194 g_variant_new("(b)", draws_attention),194 g_variant_new("(ssv)", "org.freedesktop.DisplayManager.AccountsService", "HasMessages", g_variant_new_boolean (draws_attention)),
195 NULL, /* reply */195 NULL, /* reply */
196 G_DBUS_CALL_FLAGS_NONE,196 G_DBUS_CALL_FLAGS_NONE,
197 -1, /* timeout */197 -1, /* timeout */
198198
=== modified file 'tests/accounts-service-mock.h'
--- tests/accounts-service-mock.h 2015-03-06 23:18:22 +0000
+++ tests/accounts-service-mock.h 2018-09-17 09:48:33 +0000
@@ -25,6 +25,7 @@
25 DbusTestDbusMock * mock = nullptr;25 DbusTestDbusMock * mock = nullptr;
26 DbusTestDbusMockObject * soundobj = nullptr;26 DbusTestDbusMockObject * soundobj = nullptr;
27 DbusTestDbusMockObject * userobj = nullptr;27 DbusTestDbusMockObject * userobj = nullptr;
28 DbusTestDbusMockObject * dmobj = nullptr;
28 DbusTestDbusMockObject * syssoundobj = nullptr;29 DbusTestDbusMockObject * syssoundobj = nullptr;
29 DbusTestDbusMockObject * privacyobj = nullptr;30 DbusTestDbusMockObject * privacyobj = nullptr;
3031
@@ -56,9 +57,11 @@
56 dbus_test_dbus_mock_object_add_property(mock, userobj,57 dbus_test_dbus_mock_object_add_property(mock, userobj,
57 "UserName", G_VARIANT_TYPE_STRING,58 "UserName", G_VARIANT_TYPE_STRING,
58 g_variant_new_string(g_get_user_name()), NULL);59 g_variant_new_string(g_get_user_name()), NULL);
59 dbus_test_dbus_mock_object_add_method(mock, baseobj,60
60 "SetXHasMessages", G_VARIANT_TYPE_BOOLEAN, nullptr,61 dmobj = dbus_test_dbus_mock_get_object(mock, "/user", "org.freedesktop.DisplayManager.AccountsService", NULL);
61 "", NULL);62 dbus_test_dbus_mock_object_add_property(mock, dmobj,
63 "HasMesages", G_VARIANT_TYPE_BOOLEAN,
64 g_variant_new_boolean(FALSE), NULL);
6265
63 soundobj = dbus_test_dbus_mock_get_object(mock, "/user", "com.canonical.indicator.sound.AccountsService", NULL);66 soundobj = dbus_test_dbus_mock_get_object(mock, "/user", "com.canonical.indicator.sound.AccountsService", NULL);
64 dbus_test_dbus_mock_object_add_property(mock, soundobj,67 dbus_test_dbus_mock_object_add_property(mock, soundobj,

Subscribers

People subscribed via source and target branches