Merge lp:~roadmr/isitdeployable/handle-nonexistent-revisions-in-bzr into lp:isitdeployable

[Daniel Manrique]

Handle nonexistent revisions properly.

This happens if (that we know of):

1- A branch has been rewritten and a specific commit referenced in the project is gone or nonexistent due to a typo :)

Handle nonexistent revisions properly.

This happens if (that we know of):

1- A branch has been rewritten and a specific commit referenced in the project is gone or nonexistent due to a typo :)

[Daniel Manrique (roadmr)]

Explaining myself

[Maximiliano Bertacchini (maxiberta)]

Lgtm! (check indentation nitpick)

review: Approve

[lp:~roadmr/isitdeployable/handle-nonexistent-revisions-in-bzr]

298. By Daniel Manrique on 2019-07-23

Fix indentation

[Jonathan Hartley (tartley)]

lgtm

review: Approve

=== modified file 'revtracker/tasks.py'
--- revtracker/tasks.py	2019-07-23 13:23:37 +0000
+++ revtracker/tasks.py	2019-07-23 20:41:01 +0000
@@ -240,8 +240,14 @@
         if revspec is None:
             return None
         if self.vcs == VCS.VCS_BAZAAR:
-            revid = RevisionSpec.from_string(revspec).as_revision_id(
+            try:
+                revid = RevisionSpec.from_string(revspec).as_revision_id(
                     self.branch)
+            except brz_errors.InvalidRevisionSpec as err:
+                print("%s - trying to get revspec %s from branch %s. "
+                      "Returning None" % (
+                          err, revspec, self.branch))
+                return None  # Revision not found in the branch
         else:
             try:
                 revid = self.branch.revparse_single(revspec).id.hex